Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Some description works and other misc UI improvements #10264

Merged
merged 4 commits into from
Dec 28, 2023

Conversation

kamfretoz
Copy link
Contributor

@kamfretoz kamfretoz commented Nov 10, 2023

Description of Changes

This PR attempts to fill missing description in certain sections of the settings.

See commit list for more information.

Fixes #6937

Preview:
Screenshot_20231110_221415

Rationale behind Changes

Missing Description Bad.

Suggested Testing Steps

Make sure i don't break other stuff.

@kamfretoz kamfretoz marked this pull request as ready for review December 17, 2023 13:05
@kamfretoz kamfretoz force-pushed the missing-desc branch 2 times, most recently from a2297aa to 0120e2f Compare December 17, 2023 13:11
@kamfretoz
Copy link
Contributor Author

kamfretoz commented Dec 17, 2023

Should be ready for testing.

List of Changes:

  • Added:
    • Audio -> Timestretch Settings -> Sequence Length, Seekwindow Size, Overlap.
      Screenshot_20231217_201201
    • Advanced -> VU0/1 Clamping & Rounding Mode.
      Screenshot_20231217_201225
    • Added a small warning to the Advanced Graphics tab.
      Screenshot_20231217_201330

Let me know if I'm missing more things, currently i intentionally left the Network settings as I'm pretty unfamiliar with it.

pcsx2-qt/Settings/AdvancedSettingsWidget.cpp Outdated Show resolved Hide resolved
pcsx2-qt/Settings/AdvancedSettingsWidget.cpp Show resolved Hide resolved
pcsx2-qt/Settings/AudioSettingsWidget.cpp Show resolved Hide resolved
pcsx2-qt/Settings/AudioSettingsWidget.cpp Outdated Show resolved Hide resolved
pcsx2-qt/Settings/AudioSettingsWidget.cpp Show resolved Hide resolved
To show it, enable "Show Advanced Settings" option first.
@kamfretoz
Copy link
Contributor Author

The advanced graphics option tab is now hidden by default as most users don't need to mess around in there unless under very specific circumstances.

To show it enable Tools -> "Show Advanced Settings" option.

image

@kamfretoz kamfretoz changed the title Qt/Translation: Attempt to fill in missing descriptions in settings Qt: Some description works and other misc UI improvements Dec 25, 2023
@stenzek stenzek merged commit 76e32f5 into PCSX2:master Dec 28, 2023
12 checks passed
@kamfretoz kamfretoz deleted the missing-desc branch December 28, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Several options in ui do not say what they do when hovered over with mouse
4 participants