Achievements: Use big picture to confirm HC mode disable #10323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Currently, PCSX2 if you're fullscreen and load a state while HC mode is on, because it blocks until the VM is un-fullscreened, but the VM can't un-fullscreen because it's waiting for the UI thread to confirm the mode switch.
Instead, use the big picture UI to manage it all. Works with a gamepad, and doesn't break fullscreen.
Also fixes the pause buffering "exploit" by putting a cooldown on pause hotkeys.
Rationale behind Changes
Fixes deadlocks.
Suggested Testing Steps
Try loading states while fullscreen and HC is on.
Make sure PCSX2 "works" as normal, since I changed the main CPU thread loop.