Achievements: Fix the percentage counter when only unofficial achievements exist #10328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CookiePLMonster
force-pushed
the
fix-total-unofficial-achievements
branch
from
cef84b1 to
bc94487
Compare
…ments exist Now correctly shows "This game has no achievements" and no percentage bar, as per the RetroAchievements integration guide.
CookiePLMonster
force-pushed
the
fix-total-unofficial-achievements
branch
from
bc94487 to
014c052
Compare
CookiePLMonster
changed the title
Mrlinkwii
approved these changes
Nov 28, 2023
kamfretoz
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes broken percentage display if unofficial achievements are enabled.
Rationale behind Changes
Sets with only unofficial achievements displayed wrong if unofficial test mode was enabled.
Before:
After:
Suggested Testing Steps