Achievements: Fix multiple leaderboard trackers #10338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Dependencies
kamfretoz
approved these changes
Nov 30, 2023
JordanTheToaster
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Also bumps to latest rcheevos commit.
Rationale behind Changes
Fixes #10337.
Suggested Testing Steps
Make sure achievements still work. It's difficult to test the linked issue, because it requires disabling the hardcore-disable-on-load-state behaviour. I've tested that part, so testers just need to make sure the version bump didn't break anything. Try logging out and logging in, and also intentionally failing with incorrect credentials.