Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Minor additions for translations and English text changes (2nd attempt) #10363

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

IlDucci
Copy link
Contributor

@IlDucci IlDucci commented Dec 6, 2023

Description of Changes

  • Adding translation support for all the substrings related to the single/multiframe GS Dump message.
  • Correcting the None option in the Deinterlacing settings according to what was talked about in Crowdin, unified that string with the Big Picture mode.
  • Minor English text fixes reported in Crowdin.

Second attempt at doing this PR after the former, #10253 , was mangled by bad squashing and rebasing.

Rationale behind Changes

Moar translatable strings for non-English speakers, cleaner explanation for the None option.

Suggested Testing Steps

Make sure I did not break anything, build looks good on my end.

- Adding translation support for all the substrings related to the single/multiframe GS Dump message.
- Correcting the None option in the Deinterlacing settings according to what was talked about in Crowdin, unified that string with the Big Picture mode.
- Minor English text fixes reported in Crowdin.

Second attempt at doing this PR after the former, PCSX2#10253 , was mangled by bad squashing and rebasing.
Copy link
Contributor

@HarmfulBreeze HarmfulBreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@stenzek stenzek merged commit 2bfefaf into PCSX2:master Dec 11, 2023
11 checks passed
@IlDucci IlDucci deleted the UIchanges_20231109_ROUND2 branch December 11, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants