ImGui: Make input recording frame count thread-safe #12175
+69
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd display correct value
TheTechnician27
force-pushed
the
inputrecording
branch
from
d7898dc to
cb2b94b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Make the communication between the EE (input recording) and the GS (displaying the frame count via ImGui) thread-safe. Additionally fixes a bug where the frame count was +1 what it should actually be. See #10793, which this is a follow-up to. (This fixes a small bug from that as well.)
Rationale behind Changes
Good to have the correct value displayed (previously we would run into an issue where we would say that we're on a frame that doesn't exist yet; for example, if we'd written 580 frames to an input recording and were actively recording, we'd be on frame 581). And make the code operate in a way that's not subject to a potential race condition.
Suggested Testing Steps
Test input recording to make sure 1) the correct value is displayed and 2) nothing is broken.
Fixes