Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debt to GDP plot labels #962

Merged
merged 8 commits into from
Aug 10, 2024
Merged

Conversation

jdebacker
Copy link
Member

This PR updates constants.py to allow for more variables to be plotted as a fraction of GDP.

Assertions and error messages are added to let the user know if they enter a variable that is not in the list of variables to plot.

@jdebacker
Copy link
Member Author

Related to Issue #960

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.31%. Comparing base (e799452) to head (79dcd46).
Report is 2 commits behind head on master.

Files Patch % Lines
ogcore/utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #962   +/-   ##
=======================================
  Coverage   71.31%   71.31%           
=======================================
  Files          20       20           
  Lines        4953     4958    +5     
=======================================
+ Hits         3532     3536    +4     
- Misses       1421     1422    +1     
Flag Coverage Δ
unittests 71.31% <94.11%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ogcore/constants.py 100.00% <100.00%> (ø)
ogcore/output_plots.py 95.38% <100.00%> (+0.03%) ⬆️
ogcore/parameter_tables.py 86.07% <100.00%> (ø)
ogcore/pensions.py 67.03% <100.00%> (ø)
ogcore/utils.py 87.01% <50.00%> (-0.17%) ⬇️

@rickecon
Copy link
Member

@jdebacker. Looks good. Merging.

@rickecon rickecon merged commit 6b4cccb into PSLmodels:master Aug 10, 2024
7 checks passed
@rickecon rickecon mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants