Add setuptools to pip-package in Makefile #970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
pip install setuptools
to thepip-package
section ofMakefile
. This is because thepublish_to_pypi.yml
GH Action stopped working when we moved to Python 3.12 in PR #969. The error traceback on this GH Action that only runs when a PR is merged is the following. I found in this description of What's new in Python 3.12 that this version stopped including thesetuptools
andwheel
packages. For this reason, I think the solution is to just add thepip install setuptools
line to thepip-package
section ofMakefile
. Whether this works can only be tested by merging this PR and seeing if theogcore
Python package automatically loads to PyPI.org afterward.@jdebacker