Strengthen testing of 2017_law.json and TCJA.json reform files #2217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds two new tests to the
test_reforms.py
file. The strengthened testing and the recent change in Policy.LAST_KNOWN_YEAR from 2017 to 2018 (in #2212) revealed the need for some changes in the2017_law.json
andTCJA.json
reform files and the need for one small change in the logic that implements a reform containing nonzero values of the_cpi_offset
parameter.cc @MattHJensen @codykallen