Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move license file #2706

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Move license file #2706

merged 4 commits into from
Jan 29, 2024

Conversation

jdebacker
Copy link
Member

This PR moves the license file out of the Jupyter Book documentation files to the root directory of the repo. Resolves Issue #2639.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #2706 (97664bc) into master (6798fba) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2706   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          14       14           
  Lines        2609     2609           
=======================================
  Hits         2571     2571           
  Misses         38       38           
Flag Coverage Δ
unittests 98.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
taxcalc/utils.py 97.79% <ø> (ø)

@jdebacker
Copy link
Member Author

@MattHJensen This PR is ready for your review.

The change is to move license.md out of the Jupyter Book documentation and to the root directory so that it shows up on the main page of the GH repo.

If we still feel like it should be in those docs (e.g., at https://taxcalc.pslmodels.org) then I am happy to duplicate the file and have it in both places. But Jupyter Book can't handle compiling with files above the root directory for the book.

@MattHJensen
Copy link
Contributor

@jdebacker, I think duplicate the license and then good to merge. Nice to have both places. License doesn't change, so duplication isn't a maintenance issue.

@jdebacker
Copy link
Member Author

Per @MattHJensen's suggestion, the license file has been duplicated so it ships with the documentation as well.

@jdebacker
Copy link
Member Author

@MattHJensen Do this PR look good now?

@jdebacker jdebacker merged commit 56f3528 into PSLmodels:master Jan 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants