Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a few historical income tax bracket parameter values #2730

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Mar 26, 2024

A year or two ago, there were a few mistakes made in entering by hand the values of some II_brk? and PT_brk? amounts. This pull request fixes those incorrect tax parameter values. It also fixes the reforms/rounding2022.json reform used in the round-trip-reform test so that the round-trip-reform test does not fail. Also, the expected aggregate test results for 2020 and 2021 changed slightly given the correction in the tax bracket values.

@martinholmer martinholmer marked this pull request as draft March 26, 2024 21:40
@martinholmer martinholmer marked this pull request as ready for review March 27, 2024 15:40
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (ec0a4ef) to head (d9aab06).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2730   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          13       13           
  Lines        2593     2593           
=======================================
  Hits         2578     2578           
  Misses         15       15           
Flag Coverage Δ
unittests 99.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@martinholmer martinholmer requested a review from jdebacker March 27, 2024 16:08
@jdebacker
Copy link
Member

@martinholmer Thanks for this update. I was surprise to see how off some of those values were. From some spot checking, I found no errors in your updated values. Merging.

@jdebacker jdebacker merged commit 6ababf7 into PSLmodels:master Mar 27, 2024
9 checks passed
@martinholmer martinholmer deleted the fix-pcl branch March 27, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants