Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate pylint warnings #2859

Merged
merged 48 commits into from
Jan 6, 2025
Merged

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Jan 2, 2025

Non-substantive, cosmetic changes in Python code to eliminate pylint warnings.
This work used the newest version of pylint: release 3.3.3.
The .py files in the taxcalc/validation and docs/guide directory trees were excluded from this work.

@martinholmer martinholmer marked this pull request as draft January 2, 2025 20:53
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (17bd940) to head (3223cdd).
Report is 49 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2859      +/-   ##
==========================================
+ Coverage   99.42%   99.96%   +0.53%     
==========================================
  Files          13       13              
  Lines        2625     2618       -7     
==========================================
+ Hits         2610     2617       +7     
+ Misses         15        1      -14     
Flag Coverage Δ
unittests 99.96% <100.00%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
taxcalc/calculator.py 100.00% <100.00%> (ø)
taxcalc/consumption.py 100.00% <100.00%> (ø)
taxcalc/data.py 99.25% <100.00%> (ø)
taxcalc/decorators.py 100.00% <100.00%> (ø)
taxcalc/growdiff.py 100.00% <100.00%> (ø)
taxcalc/growfactors.py 100.00% <100.00%> (ø)
taxcalc/parameters.py 100.00% <100.00%> (ø)
taxcalc/policy.py 100.00% <100.00%> (ø)
taxcalc/records.py 100.00% <ø> (ø)
taxcalc/taxcalcio.py 100.00% <100.00%> (ø)
... and 1 more

@martinholmer martinholmer reopened this Jan 4, 2025
@martinholmer martinholmer marked this pull request as ready for review January 6, 2025 16:48
@martinholmer martinholmer merged commit 02d84f7 into PSLmodels:master Jan 6, 2025
9 checks passed
@martinholmer martinholmer deleted the pylint-fixes branch January 6, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant