Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Enhancement] Add carousel to SCM Landing Page #810

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

blindaa121
Copy link
Collaborator

@blindaa121 blindaa121 commented Jan 7, 2025

Description

Preview: https://pan-dev-f1b58--pr810-0qzjphtt.web.app/strata-cloud-manager

This PR consists of suggested UI changes to the SCM Landing Page hero section by the UI/UX team. The following changes include a carousel of SCM product images, as well as an updated description.

@blindaa121 blindaa121 added the enhancement New feature or request label Jan 7, 2025
@blindaa121 blindaa121 self-assigned this Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Visit the preview URL for this PR (updated for commit 4e8c01f):

https://pan-dev-f1b58--pr810-0qzjphtt.web.app

(expires Sat, 08 Feb 2025 18:24:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9359a9fa100d5fdb082f75280473a90b1f96eb51

@blindaa121 blindaa121 changed the title Draft: [UI Enhancement] Add carousel to SCM Landing Page [UI Enhancement] Add carousel to SCM Landing Page Jan 8, 2025
@blindaa121 blindaa121 requested a review from sserrata January 8, 2025 22:36
@sserrata
Copy link
Member

sserrata commented Jan 8, 2025

Should we add the footer?

@blindaa121
Copy link
Collaborator Author

Should we add the footer?

@sserrata Ah good catch! It seems that the video overlapped the footer. Issue has been resolved in the latest commit: db8b9f3

@blindaa121 blindaa121 merged commit 191c92a into master Jan 9, 2025
6 checks passed
@blindaa121 blindaa121 deleted the scm-landing-page-update branch January 9, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants