Default "Enemy Damage Type" to "Average" #8318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7870 .
Implement Enemy Damage Type defaulting to "Average" after user swaps off of a Boss Skill Preset other than None.
Description of the problem being solved:
When users set "Boss Skill Preset" to a boss specific skill, returning to "None" would leave "Enemy Damage Type" as the type associated with that boss. This changes reverts "Enemy Damage Type" to "Average" when the user switches back to "None" from a "Boss Skill Preset" other than "None".
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/kYuRwhP1-Sm0
https://poe.ninja/builds/settlersssf/character/LPBird/Lotus_KANYQR?type=exp&i=0
Before screenshot:
Boss Skill Preset/Enemy Damage Type:
None/Average:
None/Spell:
Atziri Flameblast/Spell:
Stays on "Spell" after switching back from Atziri Flameblast:
After screenshot:
Boss Skill Preset/Enemy Damage Type:
None/Average
None/Spell
Atziri Flameblast/Spell:
Switches back to "Average" after switching back to "None" from "Atziri Flameblast"
None/Average applied correctly after automatic switch from "Spell"
Additional Note:
After working on this I decided not to pursue the option of setting "Enemy Damage Type" to a previous value set by the user, as defaulting to "Average" encapsulated most of the use cases I could imagine.