Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default "Enemy Damage Type" to "Average" #8318

Merged

Conversation

ConnorThelin
Copy link
Contributor

@ConnorThelin ConnorThelin commented Sep 24, 2024

Fixes #7870 .
Implement Enemy Damage Type defaulting to "Average" after user swaps off of a Boss Skill Preset other than None.

Description of the problem being solved:

When users set "Boss Skill Preset" to a boss specific skill, returning to "None" would leave "Enemy Damage Type" as the type associated with that boss. This changes reverts "Enemy Damage Type" to "Average" when the user switches back to "None" from a "Boss Skill Preset" other than "None".

Steps taken to verify a working solution:

  • Gathered stats for test build in several settings before change.
  • Gathered stats for test build in several settings post change.
  • Compared before/after stats to confirm that settings were being applied correctly, both manually and automatically.

Link to a build that showcases this PR:

https://pobb.in/kYuRwhP1-Sm0
https://poe.ninja/builds/settlersssf/character/LPBird/Lotus_KANYQR?type=exp&i=0

Before screenshot:

Boss Skill Preset/Enemy Damage Type:

None/Average:
image

None/Spell:
image

Atziri Flameblast/Spell:
image

Stays on "Spell" after switching back from Atziri Flameblast:
image

After screenshot:

Boss Skill Preset/Enemy Damage Type:

None/Average
image

None/Spell
image

Atziri Flameblast/Spell:
image

Switches back to "Average" after switching back to "None" from "Atziri Flameblast"
image

None/Average applied correctly after automatic switch from "Spell"
image

Additional Note:
After working on this I decided not to pursue the option of setting "Enemy Damage Type" to a previous value set by the user, as defaulting to "Average" encapsulated most of the use cases I could imagine.

Copy link
Member

@Regisle Regisle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to merge, its good to see you fixed the main issue of #8284, it would have been ideal to remember the old value, but this is good enough for now.

@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label Oct 20, 2024
@LocalIdentity LocalIdentity merged commit 22d8b27 into PathOfBuildingCommunity:dev Oct 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset 'Enemy Damage Type' after 'Boss Skill Preset' is used in configs
3 participants