Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove url encoding check, as it was broken #8372

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

Regisle
Copy link
Member

@Regisle Regisle commented Nov 22, 2024

Lua patterns dont support alternations, and the capture group I used doesnt "group" the things together within a [ ] unlike normal, so this removes the functionality, we can support it in future, but it was deemed as not a worthwhile usecase

This also fixes an issue with the sessionID on line 426 if - was used instead of #, due to account name being changed after and saved with #.

@Wires77 Wires77 merged commit 80dfb6f into PathOfBuildingCommunity:dev Nov 22, 2024
1 of 2 checks passed
@Regisle Regisle deleted the removeURLEncoding branch November 22, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants