Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Non-Damaging Ailment issue with Critical Mastery in Calc Screen #8393

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Jonathan-Dang
Copy link
Contributor

Fixed an issue where Critical Hits were not displaying the Critical Mastery Node increasing non-damaging ailment effect mod to critically strike enemies.

Fixes #8321 .

Description of the problem being solved:

Crit Mastery which increases non-damaging ailment effect modifiers did not add to the calculation menu when in crit-only mode.

Steps taken to verify a working solution:

  • Enforce build with guaranteed crit and guaranteed ailment infliction chances.
  • Node Critical Mastery which increases non-damaging ailments by 50%
  • See if Calc page increase from x 1.0 to x 1.5

Link to a build that showcases this PR:

https://pobb.in/zGdTRuRn7dWh

No Screenshots Provided.

Fixed an issue where Critical Hits were not displaying the Critical Mastery Node increasing non-damaging ailment effect mod to critically strike enemies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant