Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test module code style #31

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix test module code style #31

wants to merge 4 commits into from

Conversation

mamadaliev
Copy link

@mamadaliev mamadaliev commented Aug 3, 2019

Hello, @Patreon!
Please merge my changes if you think these changes are correct.

1. Optimize imports in PatreonAPITest and PatreonOAuthTest classes.

// from:
import org.mockito.Matchers;
import org.powermock.api.mockito.PowerMockito;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

// to:
import org.mockito.*;

2. Fix assertion to simplify in PatreonAPITest class.

// from:
assertEquals(false, campaign.isChargedImmediately());

// to:
assertFalse(campaign.isChargedImmediately());

3. Fix property access modifier to private.

// from:
PatreonOAuth oauth = ...

// to:
private PatreonOAuth oauth = ...

4. Remove "Exception" from "testAuthorizationURL" throws list.

// from:
public void testAuthorizationURL() throws Exception ...

// to:
public void testAuthorizationURL() ...

Please do not mark this as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant