Fix doUnsafeAction of Notify Controller, could not resolve gateway_name parameter defined on route #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now doUnsafeAction controller receive right gateway name from request
Run test on Laravel 6, 7, 8
Test up to PHP 7.4
Add guzzle adapter as require dependency
Add guzzle7 adapter as require dependency
Add laravel 8
Update gitignore
Is necessary a refactor of test suite or force changes on dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix an error with doUnsafeAction of Notify Controller.
This controller not resolve the gateway name parameter define in the related route, and cannot permit to use the notifications come from payment processor like Stripe.
It received the Request object as method parameter but not resolve the route parameter in the right way.
I've changed the firm of method, from
public function doUnsafeAction(Request $request)topublic function doUnsafeAction($gateway_name)as relative route "payum_notify_do_unsafe" describe in service provider.This PR is tested over PHP 7.3 and PHP 7.4, from Laravel 5.8 up to Laravel 8, using Github Actions.
It can be used on Laravel 5.1 as well, but is not actually tested from this PR. (I've test manually over a fresh L5.1 local installation)
To avoid a BC due to method firms change, i can be convert the fix try to resolve the
gateway_nameparameter through Request object.