Visualize the polygons #68
Conversation
Added install dependencies section
Co-authored-by: Chris Schnaufer <[email protected]>
Co-authored-by: Chris Schnaufer <[email protected]>
Co-authored-by: David LeBauer <[email protected]>
Co-authored-by: David LeBauer <[email protected]>
|
@im-prakher is this branch called |
|
No! It is the same branch |
|
After selecting all the relevant |
| @@ -16,8 +16,8 @@ class homepage extends Component{ | |||
| <div className="steps"> | |||
| <div><span>Steps</span></div> | |||
| <ol> | |||
| <li>Fill out Metadata in this google spreadsheet template (How to do this).</li> | |||
| <li>Prepare a shapefile or table with plot polygons (How to do this).</li> | |||
| <li>Fill out Metadata in the google spreadsheet template (<a href="https://docs.google.com/spreadsheets/d/1c_5j7q3TO6gQ24KSopE-_LXA5HhfsUEqMupckGZAbo8/edit#gid=0" rel="noopener noreferrer" target="_blank" style= { { color: "blue"} }>How to do this</a>).</li> | |||
There was a problem hiding this comment.
Maybe keep the color to what the user prefers - could impact Blue color blind people. Another possibility is to use the aria role link with css: https://www.w3.org/TR/wai-aria-1.1/#link
There was a problem hiding this comment.
isn't this just for a hyperlink? From quick research, it looks like blue hyperlinks can be distinguished from black text. e.g. this site says "The blue links on this site are easily distinguishable from plain text to all three forms of color blindness."
For the plot colors, you can find color-blind friendly palettes from here: https://colorbrewer2.org/#type=diverging&scheme=PuOr&n=5
| data.push(115); | ||
| return data | ||
| }) | ||
| const res= (await client.query('SELECT ST_Geomfromtext(ST_AsText(ST_GeomFromGeoJSON($1)),4326) As wkt', [geometry])); |
There was a problem hiding this comment.
Nice use of parameters for SQL statements!
|
The changes in this PR are reflected in #69 so I am closing this one. |
I have visualized the polygons as they should have been. Also modified the tests for that.
But in this PR I don't know why GitHub is failing to recognize the previous merged commits. As mentioned in this issue, https://stackoverflow.com/questions/16306012/github-pull-request-showing-commits-that-are-already-in-target-branch
I have already tried different methods to solve this but that didn't work for this.
Kindly, review this @Chris-Schnaufer @dlebauer @KristinaRiemer