-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
Haven't had time to test this locally, will test end of next week, @Sweetdevil144 , please bump me regarding the same :) |
@eshantri , if you find time to review this in the meantime :) |
@GandalfGwaihir will review and test this locally by Friday. Thanks! |
@Sweetdevil144 can you post a screenshot/gif of the result? Would be helpful. |
@GandalfGwaihir @Sweetdevil144 I tested the code locally, the grid issue is still there, along with weird arrangement of cards. |
Hey can you review this drive link to a video clips showing how the grid layout was laid out as I described. I think it works fine and the problem of irregular spacing is removed : https://drive.google.com/file/d/1T9uxoM4vti7ngUt3iD8P_SPqD_Ee3bc6/view?usp=sharing It is also responsive for smaller screen size as shown in the video in this drive link : https://drive.google.com/file/d/1AijsMudf1ekRhXk8UlR8sm_HzHwGOf-2/view?usp=sharing |
The goal of this issue (#34) was to remove irregular spacing between two card rowsehich was caused due to card layout. Can you explain a bit more with any 'image' example of what more changes would you like to be made for this? I'll improve the PR accordingly. @GandalfGwaihir can you checkout the drive links till then? |
@GandalfGwaihir and @eshantri . Did you verify it? |
Will verify this in a while.
…On Tue, 5 Mar, 2024, 17:32 Abhinav Pandey, ***@***.***> wrote:
@GandalfGwaihir <https://github.com/GandalfGwaihir> and @eshantri
<https://github.com/eshantri> . Did you verify it?
—
Reply to this email directly, view it on GitHub
<#38 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRT2CM4PRUQDPLUESOCI5DYWWX6HAVCNFSM6AAAAABDZDRSPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZYGYYDKNBQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@eshantri will verify this, Also :
out of context: You can directly upload a video on github issues, no need to upload them to drive and share a link :) thanks |
On going discussion on slack: https://pecanproject.slack.com/archives/D06DSNTTL9G/p1710178777928619 |
Cannot attach video_size>10mb, so attaching it via drive links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I am satisfied over here, but again @eshantri can you approve the current implemented design also ig youalso have merge access so please merge this one if approved :)
Is it, wow i was unaware all these years 😮 |
Merging this. Thanks @Sweetdevil144 @GandalfGwaihir . |
Fixes #34
Refactor layout for responsive design :