Major Update: Migrate from NAN to NAPI #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CK_ECDH2_DERIVE_PARAMS - CK_ECMQV_DERIVE_PARAMS - CK_X9_42_DH1_DERIVE_PARAMS - CK_X9_42_DH2_DERIVE_PARAMS - CK_X9_42_MQV_DERIVE_PARAMS - CK_KEA_DERIVE_PARAMS - CK_RC2_CBC_PARAMS - CK_RC2_MAC_GENERAL_PARAMS - CK_RC5_PARAMS - CK_RC5_CBC_PARAMS - CK_RC5_MAC_GENERAL_PARAMS - CK_DES_CBC_ENCRYPT_DATA_PARAMS - CK_SKIPJACK_PRIVATE_WRAP_PARAMS - CK_SKIPJACK_RELAYX_PARAMS
- CK_KEY_WRAP_SET_OAEP_PARAMS - CK_GCM_PARAMS - CK_CCM_PARAMS - CK_GOSTR3410_DERIVE_PARAMS - CK_GOSTR3410_KEY_WRAP_PARAMS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This update represents a major revision in the module's architecture, shifting from NAN (Native Abstractions for Node.js) to NAPI (Node-API). This change is pivotal for ensuring module compatibility with current and future Node.js releases.
Detailed Changes:
Adoption of NAPI: The core of this update is the transition to NAPI, a stable Node.js API designed to abstract away the underlying JavaScript engine. NAPI provides an ABI (Application Binary Interface) stable across Node.js versions, mitigating the issues related to Node.js engine updates. This shift significantly reduces the need for frequent updates with each new Node.js release, offering a more stable and consistent development experience.
API Consistency Maintained: While this update is significant in terms of internal workings, it's important to note that the external API surface remains unchanged. This design decision ensures backward compatibility, allowing existing applications to upgrade to the new module version without any code changes.
Issue Disable Signing test for Linux OS #47 Resolution: The update includes a fix for Issue Disable Signing test for Linux OS #47, enhancing the module's stability and addressing previously reported bugs.
Enhanced Testing Suite and CI Updates: Complementing the shift to NAPI, the module's testing suite has been expanded to cover new scenarios introduced by this change. This comprehensive testing ensures that both new and existing functionalities perform as expected. Additionally, the CI (Continuous Integration) environment has been updated to align with these changes, optimizing our development and deployment workflow.
Implementation of Dual-function Cryptographic Operations: A significant addition in this update is the implementation of dual-function cryptographic operations, including
C_DigestEncryptUpdate,C_DecryptDigestUpdate,C_SignEncryptUpdate, andC_DecryptVerifyUpdate. These operations expand the module's capabilities, allowing for more complex cryptographic tasks within a single operation.Implications and Recommendations:
This transition to NAPI, while maintaining API compatibility, necessitates a major version bump due to the underlying architectural changes. Users are strongly encouraged to upgrade to this latest version for improved stability and forward compatibility with future Node.js versions. The upgrade process should be seamless, given the preserved API interface.