Intitial commit of Block Interval Auctions #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrit
reviewed
Dec 13, 2023
|
|
||
| } | ||
|
|
||
| func (suite *KeeperTestSuite) TestAuctionBeginWithInSufficientFunds() { |
There was a problem hiding this comment.
I don't think I understand what this is testing. Does the module account implicitly have a zero balance? Why is BeginAuction being called if that's the case?
| expectedEmission := sdk.NewCoin(appParams.BaseCoinUnit, event.Amount) | ||
| suite.bankKeeper.EXPECT().SendCoinsFromModuleToModule(ctx, gomock.Any(), gomock.Any(), sdk.NewCoins(expectedEmission)).Times(1) | ||
| suite.auctionKeeper.EXPECT().GetActiveAuctions(ctx).Return([]*auctionTypes.Auction{}) | ||
| suite.bankKeeper.EXPECT().GetBalance(ctx, feesAccount.GetAddress(), gravityFeeDenom).Return(sdk.NewCoin(gravityFeeDenom, event.Amount)) |
There was a problem hiding this comment.
shouldn't it not get to these calls (inside of k.beginAuction) if the height modulo isn't zero (which i thought is what the test name implies)?
| cellarfeesTypes "github.com/peggyjv/sommelier/v7/x/cellarfees/types" | ||
| ) | ||
|
|
||
| func (suite *KeeperTestSuite) TestBeginBlockerZeroRewardsBalance() { | ||
| ctx, cellarfeesKeeper := suite.ctx, suite.cellarfeesKeeper | ||
|
|
There was a problem hiding this comment.
I think you need to add the same fee accrual initialization here, the test panics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit of Cellar Interval Auctions