Token not cleared from MySQL upon logout #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for putting so much effort into this.
I noticed, after using this repo, that when logging out of the application the token associated with the username is not deleted from the token store table
tokens
. Therefore, I created a function calleddestroy
which will attempt to delete the token from the database before existing, just like what you are doing with the session management repo.Also, are you guys planning to implement the logic for the refresh token?