Migrate to latest Android SDK, AGP and protobuf plugin #763

ened · 2023-07-05T21:24:29Z

Bumps the AGP and Gradle versions, so that modern Android Studio can compile happily.
Bumps the compile and targetSDK to 33, so that new APIs are available (needed for Adds support for Android companion pairing, device bonding, iOS device name (via GAP) #760)
Update the protobuf plugin, as this would cause issues on modern build environments (like this one, but also from developer reports, see AGP fails due to com.google.protobuf version #761)

fixes #630
fixes #761

closes #754

ened · 2023-07-05T21:25:27Z

cc @remonh87 @Taym95

ened · 2023-07-06T10:52:50Z

@Taym95 I suggest we merge #762 first, then I rebase, so the checks will pass.

Taym95 · 2023-07-06T11:31:53Z

@Taym95 I suggest we merge #762 first, then I rebase, so the checks will pass.

Yes sure!

* Bumps to Dart 2.17 minimum and upgrades melos to 3.1.0 * Update root pubspec.yaml with the correct workspace name Co-authored-by: Taym Haddadi <[email protected]> * add missing underscore --------- Co-authored-by: Taym Haddadi <[email protected]>

…_ble into android-agp-update

ened · 2023-07-06T14:38:44Z

@Taym95 the build failed but I can not see the logs; please could you invite me to code magic so that I can ?

Taym95 · 2023-07-06T15:58:08Z

@Taym95 the build failed but I can not see the logs; please could you invite me to code magic so that I can ?

I will invite you:

Welcome to Gradle 8.0!

For more details see https://docs.gradle.org/8.0/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build failed with an exception.

Where:
Build file '/Users/builder/clone/example/android/app/build.gradle' line: 24
What went wrong:
A problem occurred evaluating project ':app'.

Failed to apply plugin 'com.android.internal.application'.
Android Gradle plugin requires Java 17 to run. You are currently using Java 11.
Your current JDK is located in /Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home
You can try some of the following options:
- changing the IDE settings.
- changing the JAVA_HOME environment variable.
- changing org.gradle.java.home in gradle.properties.

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 33s

Build failed :|
Step 6 script Android native tests exited with status code 1

Taym95 · 2023-07-06T16:05:58Z

You need to set JAVA version in:

    environment:
      flutter: stable
      xcode: 13.3
      cocoapods: default
 ->  java: 1.8         # Define default, or platform version (e.g. 11)

ened · 2023-07-07T06:20:06Z

@Taym95 I created a personal codemagic account and the build runs through - wondering what the issue is here?

Taym95 · 2023-07-10T15:34:48Z

@Taym95 I created a personal codemagic account and the build runs through - wondering what the issue is here?

Still same issues;

`

What went wrong:
A problem occurred evaluating project ':app'.

Failed to apply plugin 'com.android.internal.application'.
Android Gradle plugin requires Java 17 to run. You are currently using Java 11.
Your current JDK is located in /Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home
You can try some of the following options:
- changing the IDE settings.
- changing the JAVA_HOME environment variable.
- changing org.gradle.java.home in gradle.properties.`

Taym95 · 2023-07-12T13:13:58Z

@remonh87 please add @ened to codemagic I don't have admin right to add to the team anymore

remonh87 · 2023-07-12T13:31:59Z

@Taym95 I am not part of the ble team anymore in codemagic. @werediver is admin he can add him. I personally think we should make the build results available public if possible, else maybe we need to consider a different CI

ened · 2023-07-12T16:19:18Z

Is there a world in which you'd accept a PR to switch to GitHub actions altogether?
Works great for flutter and is free for open source projects.

@Taym95 @remonh87 @werediver

werediver · 2023-07-13T09:35:17Z

@remonh87 please add @ened to codemagic I don't have admin right to add to the team anymore

@Taym95 You are the owned of the team, so you should have all the rights.

Regardless, the fix is explained above. @ened can implement the fix without being a member of that Codemagic team, it's just a YAML-file change (the file is in the repo, "codemagic.yaml").

ened · 2023-07-13T09:47:29Z

Regardless, the fix is explained above. @ened can implement the fix without being a member of that Codemagic team, it's just a YAML-file change (the file is in the repo, "codemagic.yaml").

I did, but it still fails. So access to the CI is needed for efficient debugging.

werediver · 2023-07-13T09:53:03Z

Codemagic seems to use "codemagic.yaml" from the main branch when building a p/r. The configuration should be updated in a separate p/r.

@Taym95 If you're willing, you may be in a better position updating Codemagic configuration, because you can see all the CI stuff.

ened · 2023-07-14T07:02:58Z

Codemagic seems to use "codemagic.yaml" from the main branch when building a p/r. The configuration should be updated in a separate p/r.

@werediver This won't work - the gradle system in use currently is not compatible with Java19. This will yield class file errors like:

* What went wrong:
Could not open settings generic class cache for settings file '/Users/builder/clone/example/android/settings.gradle' (/Users/builder/.gradle/caches/7.0.2/scripts/1445wdyck9xmnqxfk9atcnkpf).
> BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 63

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

My suggestion is to merge this PR now (as mentioned I tested on. my personal code magic account and built the branch directly).

If things are not right, you can always revert.

Rexios80 · 2023-08-07T14:32:17Z

Any progress on this? We need protobuf updated to update other packages.

remonh87 · 2023-08-07T18:55:38Z

@ened can you update the java runtime to 17?


A problem occurred evaluating project ':app'.
> Failed to apply plugin 'com.android.internal.application'.
   > Android Gradle plugin requires Java 17 to run. You are currently using Java 11.
      Your current JDK is located in /Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home
      You can try some of the following options:
       - changing the IDE settings.
       - changing the JAVA_HOME environment variable.
       - changing `org.gradle.java.home` in `gradle.properties`.

cenumi · 2023-09-19T02:31:36Z

any updates?

PieterAelse · 2023-09-20T20:39:57Z

packages/reactive_ble_mobile/android/gradle.properties

@@ -1,4 +0,0 @@
-org.gradle.jvmargs=-Xmx3072m


Is it correct this file is removed? 🤔

Not really. It should stay.

PieterAelse · 2023-09-20T20:40:07Z

packages/reactive_ble_mobile/android/gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +0,0 @@
-#Wed Sep 29 14:33:41 CEST 2021
-distributionBase=GRADLE_USER_HOME


Is it correct this file (also) is removed? 🤔

Also, should be there to let devs of the package specify which Gradle wrapper version to use.

nathanielheitsch · 2023-10-03T13:31:54Z

Any update on this?

remonh87 · 2023-11-21T10:19:44Z

@ened do you need help with the last remarks. I really would like to integrate it so we are compliant to AGP8 and new protobuf

AndreaBalde · 2023-12-06T08:01:10Z

Any update on this merge request?

vbuberen · 2024-01-08T09:28:11Z

@Taym95 @werediver
Which help is needed to move this topic forward? I can step in and help if needed as did the same update to AGP 8 in other packages last year as well: firebase/flutterfire#11699

Currently, flutter_reactive_ble not supporting AGP 8 blocks one of my work projects, so I would like to help here if needed to make this thing merged faster.

Taym95 · 2024-01-11T13:05:03Z

This was merged with #830

ened mentioned this pull request Jul 5, 2023

AGP fails due to com.google.protobuf version #761

Closed

ened mentioned this pull request Jul 5, 2023

Adds support for Android companion pairing, device bonding, iOS device name (via GAP) #760

Open

Taym95 approved these changes Jul 6, 2023

View reviewed changes

ened and others added 4 commits July 6, 2023 15:20

chore: Migrate to latest Android SDK, AGP and protobuf plugin

cb58e8a

Remove unused file

35a2e76

after melos bootstrap

eedc3d3

ened force-pushed the android-agp-update branch from f64c314 to eedc3d3 Compare July 6, 2023 14:21

ened added 3 commits July 6, 2023 15:21

Merge branch 'master' into android-agp-update

e8fda40

Merge branch 'master' into android-agp-update

da1c0b5

Merge branch 'android-agp-update' of github.com:ened/flutter_reactive…

eae20e7

…_ble into android-agp-update

ened added 3 commits July 7, 2023 06:55

java 18

6ac3e7e

cleanups

869c2ef

java 19

6e91f1c

ened added 8 commits July 10, 2023 20:35

Merge branch 'master' into android-agp-update

e6f915c

java 19.0.2 (explicit)

8cd76e9

switch to xcode 14.3 image

9ce8e7d

try without bash -ex wrapper

d4ed433

adjust path manually

a71f027

set java home via local.properties

82efad4

debug log

93a5f19

only collect 1 apk

7c7a1e0

adjust quality script to not re-source .bashrc

303a1b9

This was referenced Jul 12, 2023

Upgrade protobuf #754

Closed

Adds namespace to build.gradle to support Gradle 8 #767

Closed

Merge branch 'master' into android-agp-update

8e1f496

Merge branch 'master' into android-agp-update

f52bd60

PieterAelse approved these changes Sep 20, 2023

View reviewed changes

Taym95 mentioned this pull request Jan 11, 2024

Add Github actions and Migrate to latest Android SDK, AGP and protobuf plugin #830

Merged

Taym95 closed this Jan 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to latest Android SDK, AGP and protobuf plugin #763

Migrate to latest Android SDK, AGP and protobuf plugin #763

ened commented Jul 5, 2023 •

edited

Loading

ened commented Jul 5, 2023

ened commented Jul 6, 2023

Taym95 commented Jul 6, 2023

ened commented Jul 6, 2023

Taym95 commented Jul 6, 2023 •

edited

Loading

Taym95 commented Jul 6, 2023

ened commented Jul 7, 2023

Taym95 commented Jul 10, 2023

Taym95 commented Jul 12, 2023

remonh87 commented Jul 12, 2023

ened commented Jul 12, 2023

werediver commented Jul 13, 2023

ened commented Jul 13, 2023

werediver commented Jul 13, 2023

ened commented Jul 14, 2023

Rexios80 commented Aug 7, 2023

remonh87 commented Aug 7, 2023

cenumi commented Sep 19, 2023

PieterAelse Sep 20, 2023

vbuberen Dec 11, 2023

PieterAelse Sep 20, 2023

vbuberen Dec 11, 2023

nathanielheitsch commented Oct 3, 2023

remonh87 commented Nov 21, 2023

AndreaBalde commented Dec 6, 2023

vbuberen commented Jan 8, 2024

Taym95 commented Jan 11, 2024

		@@ -1,6 +0,0 @@
		#Wed Sep 29 14:33:41 CEST 2021
		distributionBase=GRADLE_USER_HOME

Migrate to latest Android SDK, AGP and protobuf plugin #763

Migrate to latest Android SDK, AGP and protobuf plugin #763

Conversation

ened commented Jul 5, 2023 • edited Loading

ened commented Jul 5, 2023

ened commented Jul 6, 2023

Taym95 commented Jul 6, 2023

ened commented Jul 6, 2023

Taym95 commented Jul 6, 2023 • edited Loading

Taym95 commented Jul 6, 2023

ened commented Jul 7, 2023

Taym95 commented Jul 10, 2023

Taym95 commented Jul 12, 2023

remonh87 commented Jul 12, 2023

ened commented Jul 12, 2023

werediver commented Jul 13, 2023

ened commented Jul 13, 2023

werediver commented Jul 13, 2023

ened commented Jul 14, 2023

Rexios80 commented Aug 7, 2023

remonh87 commented Aug 7, 2023

cenumi commented Sep 19, 2023

PieterAelse Sep 20, 2023

Choose a reason for hiding this comment

vbuberen Dec 11, 2023

Choose a reason for hiding this comment

PieterAelse Sep 20, 2023

Choose a reason for hiding this comment

vbuberen Dec 11, 2023

Choose a reason for hiding this comment

nathanielheitsch commented Oct 3, 2023

remonh87 commented Nov 21, 2023

AndreaBalde commented Dec 6, 2023

vbuberen commented Jan 8, 2024

Taym95 commented Jan 11, 2024

ened commented Jul 5, 2023 •

edited

Loading

Taym95 commented Jul 6, 2023 •

edited

Loading