Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add perl to pd base image #112

Merged
merged 2 commits into from
Nov 9, 2023
Merged

feat: add perl to pd base image #112

merged 2 commits into from
Nov 9, 2023

Conversation

jayl1e
Copy link
Contributor

@jayl1e jayl1e commented Nov 9, 2023

Why:

  • add perl to pd

Copy link

ti-chi-bot bot commented Nov 9, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:

The Pull Request adds perl to the pd base image. It changes the Dockerfile by adding the 'perl-interpreter' package in the RUN command.

Potential problems:

It seems like there are no potential problems in this Pull Request.

Fixing suggestions:

As there are no potential problems with this Pull Request, no fixing suggestions are needed. However, it might be helpful to add more information to the Pull Request description, such as the reason why perl was added to the pd base image or how it will benefit the project.

@ti-chi-bot ti-chi-bot bot requested review from purelind and wuhuizuo November 9, 2023 04:00
@ti-chi-bot ti-chi-bot bot added the size/XS label Nov 9, 2023
Copy link
Contributor

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 9, 2023
Copy link

ti-chi-bot bot commented Nov 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-09 05:52:48.407878648 +0000 UTC m=+3709965.994988778: ☑️ agreed by wuhuizuo.

Copy link

ti-chi-bot bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 9, 2023
@ti-chi-bot ti-chi-bot bot merged commit 1993978 into main Nov 9, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the chore/perl branch November 9, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants