Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dockerfiles/cd): refactor multi stages building dockerfiles for tiflow #118

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

wuhuizuo
Copy link
Contributor

  • include components: ticdc, dm
  • also fix build step for pd image

Signed-off-by: wuhuizuo [email protected]

…for tiflow

- include components: ticdc, dm
- also fix build step for pd image

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind November 10, 2023 12:51
Copy link

ti-chi-bot bot commented Nov 10, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.

Review of "refactor(dockerfiles/cd): refactor multi stages building dockerfiles for tiflow"

Summary

This Pull Request is a refactor of multi-stage building Dockerfiles for Tiflow. The changes include the inclusion of components ticdc and dm, as well as fixing the build step for the pd image. The changes include modifications to build steps and Dockerfiles.

Potential Problems

  1. The Dockerfile for dm and ticdc are deleted, and new Dockerfiles are added to a different directory. This change could break the existing pipeline or scripts that depend on the previous Dockerfiles.
  2. The docker build command in msb-dm and msb-ticdc does not have a --no-cache flag, which could lead to an unsuccessful build due to the use of outdated cached layers.

Suggestions

  1. Before deleting the older Dockerfiles, it's important to verify that no other pipelines or scripts depend on them. If there are any dependencies, they should be updated before deleting the old files.
  2. Add the --no-cache flag to the docker build command in msb-dm and msb-ticdc to ensure that the latest changes are built.

Overall

The Pull Request seems to be well-documented and includes necessary changes. However, it is crucial to ensure that the changes do not break the existing pipeline or scripts.

@ti-chi-bot ti-chi-bot bot added the size/L label Nov 10, 2023
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 10, 2023
@ti-chi-bot ti-chi-bot bot merged commit a348d85 into main Nov 10, 2023
1 check passed
@ti-chi-bot ti-chi-bot bot deleted the feature/msb-docker-file-for-tiflow branch November 10, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant