Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps/prod/tekton/configs/pipelines): add a new darwin build pipeline #1370

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Dec 9, 2024

  • combine multi tasks into one task: acquire resource then build with
    the resource machine then release the resource.
  • just use deno for run for build.

based on implement: PingCAP-QE/artifacts#503

Signed-off-by: wuhuizuo [email protected]

…line

- combine multi tasks into one task: acquire resource then build with
    the resource machine then release the resource.
- just use deno for run for build.

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from purelind December 9, 2024 12:31
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster size/XL labels Dec 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 9, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

The pull request introduces a new build pipeline for a darwin build. Here are the key changes:

  1. A new pingcap-build-package-darwin-v2.yaml file is added to the apps/prod/tekton/configs/pipelines directory. It defines a new tekton pipeline for darwin builds.

  2. A new pingcap-build-binaries-darwin-v2.yaml file is added to the apps/prod/tekton/configs/tasks directory. It defines a new tekton task for building binaries for darwin.

  3. Changes are made to kustomization.yaml files in apps/prod/tekton/configs/pipelines and apps/prod/tekton/configs/tasks directories to include the newly added pipeline and task.

  4. Changes are made to pingcap-build-package-darwin.yaml and pingcap-build-binaries.yaml to replace hardcoded darwin value with parameter.

  5. Changes in pingcap-build-binaries-darwin.yaml also includes updating the tekton.dev/platforms annotation to support both linux/amd64 and linux/arm64.

Potential issues:

  1. The pingcap-build-binaries-darwin-v2.yaml task uses the docker.io/denoland/deno:alpine-2.1.3 image for the build step. Make sure this image is available and compatible with the build requirements.

  2. The build script in pingcap-build-binaries-darwin-v2.yaml clones the PingCAP-QE/artifacts repo. Ensure the repo URL and branch (main) are correct.

  3. The pingcap-build-binaries-darwin-v2.yaml task uses ssh credentials for remote building on mac. Make sure these credentials are available and have proper access rights.

Suggestions for fixing:

  1. Verify the compatibility of the docker.io/denoland/deno:alpine-2.1.3 image with the build requirements.

  2. Check the availability and access to the PingCAP-QE/artifacts repo.

  3. Make sure the ssh credentials used for remote building on mac are available and have proper access rights.

  4. Check if the pipeline and task configurations are correct and adhere to the tekton specifications.

  5. Check if the hardcoded values replaced with parameters in pingcap-build-package-darwin.yaml and pingcap-build-binaries.yaml have correct and valid values when the pipeline runs.

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Dec 9, 2024

Test results

image image image

Copy link
Contributor

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

ti-chi-bot bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-10 02:14:56.082961762 +0000 UTC m=+318286.171764312: ☑️ agreed by purelind.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 10, 2024
@ti-chi-bot ti-chi-bot bot merged commit e38d1aa into main Dec 10, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/improve-darwin-build-pipeline branch December 10, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster lgtm size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants