feat(apps/prod/tekton/configs): switch to new darwin build pipeline in trigger templates

[wuhuizuo]

• switch to pipeline: pingcap-build-package-darwin-v2
• Add checking steps before publishing to avoid corrupt artifacts.

Signed-off-by: wuhuizuo [email protected]

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request diff, it seems that the changes are related to avoiding corrupt artifacts in the Darwin builds. Specifically, there are changes in the pipeline task names, parameters related to the force-builder-image, and the addition of the Boskos server URL.

There don't seem to be any potential problems with the changes in this pull request. However, it could be helpful to provide more context in the pull request description to explain the reasoning behind the changes.

As for fixing suggestions, it could be helpful to include more information on how to test the changes and ensure that the artifacts are no longer being corrupted. Additionally, it might be useful to provide some background on the Boskos server URL and how it's being used in this context.

[wuhuizuo]

/review default

[ti-chi-bot]

@wuhuizuo:

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the title and description of the pull request, the key changes made are:

• Switching to a new pipeline pingcap-build-package-darwin-v2.
• Adding checking steps before publishing to prevent corrupt artifacts.

After reviewing the diff, I have identified the following potential problems:

• The finally timeout for releasing the resources of the darwin machine is removed. It is recommended to keep a buffer time to avoid resource waste.
• The changes made for acquiring and releasing mac machines are removed. It is recommended to add these steps back to the pipeline as they are necessary for the build process.
• The boskos-server-url parameter is added without any context or explanation. It would be better to add some documentation regarding this parameter to make it clear for other developers.

To fix these issues, I suggest the following:

• Add a buffer time for releasing the resources of the darwin machine.
• Add back the steps for acquiring and releasing mac machines in the pipeline.
• Add documentation regarding the boskos-server-url parameter to clarify its purpose.

Once these changes are made, the pull request can be approved.

In response to this:

/review default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the key changes are as follows:

1. The pipeline used for building binaries on macOS has been changed from pingcap-build-package-darwin to pingcap-build-package-darwin-v2.
2. Checking steps have been added before publishing to avoid corrupt artifacts.

Potential problems:

1. It is unclear what exactly the checking steps are and how they avoid corrupt artifacts. It would be helpful to have more information on this.
2. The pingcap-build-package-darwin pipeline is being used for both darwin/amd64 and darwin/arm64 architectures. However, the pingcap-build-package-darwin pipeline is not designed to work with darwin/arm64 architecture. This could lead to unexpected issues.

Fixing suggestions:

1. Provide more information on the newly added checking steps to avoid confusion.
2. Create a separate pipeline for darwin/arm64 architecture or modify the existing pipeline to support darwin/arm64.

[wuhuizuo]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• apps/prod/OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment