Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton/configs/tasks): update image tag of crane #1374

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Now only latest exists on the repo.

Signed-off-by: wuhuizuo [email protected]

Now only `latest` exists on the repo.

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from purelind December 12, 2024 06:08
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Dec 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 12, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the key change being made is to update the image tag for the gcr.io/go-containerregistry/crane/debug image from v0.15.2 to latest in the pingcap-deliver-image.yaml file.

There are no apparent potential problems with this change, as it simply updates the image tag to the latest available version.

However, it is worth noting that relying on the latest tag for image versions can be problematic in certain situations, as it may not always point to the same image. It is recommended to use specific version tags wherever possible to ensure consistency.

As for fixing suggestions, it may be worth considering using a specific version tag for the image instead of latest, if possible. Additionally, it is a good practice to test the updated code before merging it to ensure that there are no unintended consequences of the change.

@ti-chi-bot ti-chi-bot bot added the size/XS label Dec 12, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9a65916 into main Dec 12, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/crane-image branch December 12, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant