Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(apps/prod/tekton/configs/pipelines): make results of darwin pipeline be same with linux pipeline #1376

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo [email protected]

…pipeline be same with linux pipeline

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from purelind December 13, 2024 06:57
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Dec 13, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes aim to make the results of the darwin pipeline the same as the linux pipeline. From the diff, it appears that a new step has been added to the darwin pipeline to push images, which was missing before. However, there are a few issues that need to be addressed:

  1. The value field for pushed-images in the darwin pipeline is using the wrong value. It should be "$(tasks.build-images.results.printed)" instead of "$(tasks.build-binaries.results.pushed)".
  2. The echo task for build-images is not useful as it doesn't do anything. It should be replaced with a push task to push the built images.
  3. There is no test plan provided in the pull request description, which makes it hard to verify if the changes are working as expected.

Here are some suggestions to fix the issues:

  1. Update the value field for pushed-images in the darwin pipeline to "$(tasks.build-images.results.printed)".
  2. Replace the echo task for build-images with a push task to push the built images.
  3. Add a test plan to verify that the changes are working as expected, for example, by running the darwin pipeline and comparing the results with the linux pipeline.

@ti-chi-bot ti-chi-bot bot added the size/S label Dec 13, 2024
Copy link
Collaborator Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 13, 2024
@ti-chi-bot ti-chi-bot bot merged commit b2143f6 into main Dec 13, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/dev-build-1 branch December 13, 2024 07:02
wuhuizuo added a commit that referenced this pull request Dec 13, 2024
…pipeline be same with linux pipeline (#1376)

Signed-off-by: wuhuizuo <[email protected]>

Signed-off-by: wuhuizuo <[email protected]>
wuhuizuo added a commit that referenced this pull request Dec 13, 2024
…pipeline be same with linux pipeline (#1376)

Signed-off-by: wuhuizuo <[email protected]>

Signed-off-by: wuhuizuo <[email protected]>
wuhuizuo added a commit that referenced this pull request Dec 18, 2024
…pipeline be same with linux pipeline (#1376)

Signed-off-by: wuhuizuo <[email protected]>

Signed-off-by: wuhuizuo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant