Update __func__ and __PRETTY_FUNCTION__ defines for MSVC #6222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larshg
reviewed
Jan 21, 2025
common/include/pcl/pcl_macros.h
Outdated
| @@ -217,7 +217,6 @@ | |||
| #endif | |||
|
|
|||
| #define __PRETTY_FUNCTION__ __FUNCTION__ | |||
There was a problem hiding this comment.
Suggested change
| #define __PRETTY_FUNCTION__ __FUNCTION__ | |
| #define __PRETTY_FUNCTION__ __FUNCSIG__ |
See: https://godbolt.org/z/T3P4PWfoj and https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-140
Co-authored-by: Lars Glud <[email protected]>
watk
changed the title
#define __func__ from pcl_macros.h
watk
changed the title
watk
changed the title
larshg
approved these changes
Jan 22, 2025
mvieth
added
module: common
changelog: fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the function name preprocessor defines for modern MSVC. Specifically:
#define __func__because MSVC has supported this standard define since Visual Studio 2015, and pcl only supports Visual Studio 2017 and newer.__PRETTY_FUNCTION__to MSVC's__FUNCSIG__instead of the previous alias to__FUNCTION__, because the former is a better match.Note: I haven't tested this change.
Fixes #6220