Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Photo and Video Gallery Feature #120

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

anjali24671
Copy link

Implement Photo and Video Gallery Feature

Fixes #4

Video/Screenshots (mandatory)

image
image

image

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have gone through the contributing.md file before contributing

Additional context:

Copy link

gitguardian bot commented May 13, 2024

⚠️ GitGuardian has uncovered 11 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9250661 Triggered Generic High Entropy Secret de739a9 Pages/earthPics/script.js View secret
9250661 Triggered Generic High Entropy Secret 30bfe3b app.js View secret
9250661 Triggered Generic High Entropy Secret 99a3026 Pages/asteroid-info/script.js View secret
9250661 Triggered Generic High Entropy Secret 76b1fbf Pages/asteroid-info/script.js View secret
9250661 Triggered Generic High Entropy Secret af167a0 Pages/asteroid-info/script.js View secret
9250661 Triggered Generic High Entropy Secret 99a3026 Pages/earthPics/script.js View secret
9250661 Triggered Generic High Entropy Secret 76b1fbf Pages/earthPics/script.js View secret
9250661 Triggered Generic High Entropy Secret 30bfe3b app.js View secret
9250661 Triggered Generic High Entropy Secret f847722 Pages/asteroid-info/script.js View secret
9250661 Triggered Generic High Entropy Secret 30bfe3b app.js View secret
9250661 Triggered Generic High Entropy Secret de739a9 Pages/asteroid-info/script.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Owner

@PranavBarthwal PranavBarthwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work @anjali24671!
Few changes :

  • create a new folder named pages
  • create new folder inside pages named gallery where you can store the html, css, js files
  • add the existing navbar and footer to maintain a consistent look across all pages.

thanks

@anjali24671
Copy link
Author

@PranavBarthwal, Thankyou so much. I have added all 3 changes. kindly have a review.

@PranavBarthwal PranavBarthwal self-requested a review May 14, 2024 19:45
Copy link
Owner

@PranavBarthwal PranavBarthwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folder structure is still not fixed ig.

@anjali24671
Copy link
Author

@PranavBarthwal I've changed the structure

@anjali24671
Copy link
Author

@PranavBarthwal please have a look at the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Photo and Video Gallery Feature
2 participants