Fix Horadric recipes #465
Merged
Fix Horadric recipes #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PiotrKaszuba
commented
Oct 8, 2024
PiotrKaszuba
commented
- Fixed: _get_average_ingredient_level which only skips numerator additions for non-permanent items while keeps denominator the size of item list - influences/fixes Imbue recipe
- Removed unnecessary luck messages for recipes that are not influenced by luck
…unting permanent items - previously non-permanent items were skipped but still counted for division as size of item list was used
No change to behavior Generate permanent item list and use it to get, sum, item count and \ avg level
|
Thank you. |
Kvel2D
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.