Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix division by zero in average item level #470

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Fix division by zero in average item level #470

merged 2 commits into from
Oct 10, 2024

Conversation

PiotrKaszuba
Copy link
Contributor

fix undefined value returned when no permanent items in horadric cube

Kvel2D
Kvel2D approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@Kvel2D Kvel2D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, merged.

Note that there's Utils.divide_safe() function for such cases.

@Kvel2D Kvel2D merged commit b268cbb into Praytic:main Oct 10, 2024
@PiotrKaszuba PiotrKaszuba deleted the fix_average_item_level branch October 10, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kvel2D Kvel2D Kvel2D approved these changes

@Praytic Praytic Awaiting requested review from Praytic Praytic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PiotrKaszuba @Kvel2D