Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docstring state.result for when used with run_deployment #15509

Conversation

benjamincerigo
Copy link
Contributor

@benjamincerigo benjamincerigo commented Sep 27, 2024

To give light on the complex behaviour of state.result when used with run_deployment.

Closes #15276

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

To give light on the complex behaviour of `state.result` when used with
`run_deployment`.

Closes issue: PrefectHQ#15276
@github-actions github-actions bot added the bug Something isn't working label Sep 27, 2024
@benjamincerigo benjamincerigo changed the title Improve docstring result for when used with run_deployment Improve docstring state.result for when used with run_deployment Sep 27, 2024
Copy link

codspeed-hq bot commented Sep 27, 2024

CodSpeed Performance Report

Merging #15509 will not alter performance

Comparing benjamincerigo:improve_docs_state_result_raise_on_failure (e832383) with main (953b733)

Summary

✅ 3 untouched benchmarks

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@desertaxle desertaxle merged commit 1f53392 into PrefectHQ:main Sep 30, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent raise_on_failure=True behaviour for flow_run.state.result() when using run_deployment
2 participants