moving all pendulum use into prefect.types
#16609
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
changed the title
prefect.typespendulum use into prefect.types
zzstoatzz
commented
Jan 5, 2025
Comment on lines
-71
to
-91
| def __rich_repr__(self) -> RichReprResult: | ||
| # Display all of the fields in the model if they differ from the default value | ||
| for name, field in self.model_fields.items(): | ||
| value = getattr(self, name) | ||
|
|
||
| # Simplify the display of some common fields | ||
| if field.annotation == UUID and value: | ||
| value = str(value) | ||
| elif ( | ||
| isinstance(field.annotation, datetime.datetime) | ||
| and name == "timestamp" | ||
| and value | ||
| ): | ||
| value = cast(pendulum.DateTime, pendulum.instance(value)).isoformat() | ||
| elif isinstance(field.annotation, datetime.datetime) and value: | ||
| value = cast( | ||
| pendulum.DateTime, pendulum.instance(value) | ||
| ).diff_for_humans() | ||
|
|
||
| yield name, value, field.get_default() | ||
|
|
There was a problem hiding this comment.
i could keep this..... but why?
zzstoatzz
commented
Jan 5, 2025
| @@ -802,7 +807,7 @@ async def run( | |||
| warnings.filterwarnings("ignore", module="dateparser") | |||
|
|
|||
| try: | |||
| start_time_parsed = dateparser.parse( | |||
| start_time_parsed = dateparser.parse( # type: ignore TODO: remove this? | |||
There was a problem hiding this comment.
i really don't understand why this exists either
zzstoatzz
added
development
CodSpeed Performance ReportMerging #16609 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #16472 and pydantic/pydantic-extra-types#239
preliminary steps towards removing
pendulumentirely