Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End to end #1

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

End to end #1

wants to merge 13 commits into from

Conversation

ekrathSNL
Copy link
Collaborator

Completed end to end example.

@eparish1 eparish1 self-requested a review August 15, 2024 20:09
@eparish1
Copy link
Contributor

@ekrathSNL

Thanks, the end-to-end demo looks very nice! A few things:

  • The PR has committed changes for the "basic_sampling.py" tutorial where you comment out most of the code. Could you revert this to the version that is currently in master?
  • What is the docs/notebooks/.python-version addition?
  • I noticed you commented out the html theme and some of the theme settings, is there a reason?

Thanks!!

@ekrathSNL
Copy link
Collaborator Author

Pushed commits that fix basic_sampling (this will be overwritten by the krathedits branch) and the conf.py file. I modified the html of the conf.py file when I was messing with figures.

I don't know what the .python-version addition is. It exists, but I can't remove it with git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants