Add the Controllable (Fabric) Mod #263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the Controllable (Fabric) mod and corrects "Controllable" to "Controllable (Forge)" to stay up to date. Signed-off-by: Champe25 <[email protected]>
✅ Deploy Preview for prismlauncher ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
DioEgizio
reviewed
May 1, 2023
| @@ -22,9 +22,15 @@ Finally, if you don't have one already, you must create an **instance** with the | |||
|
|
|||
| Before you continue, ensure that the correct version of the **Fabric API** mod on **Fabric** or the **Quilted Fabric API** mod on **Quilt** for your instance is installed. | |||
|
|
|||
| ### <img src="https://raw.githubusercontent.com/MrCrayfish/Controllable/6caef1a4ac113e5c6ac1d1abde0f0cabc3e6ad97/src/main/resources/controllable_icon.png" height="20"> Controllable (Fabric) (for Minecraft Versions 1.18 or newer) | |||
|
|
|||
| For Minecraft versions 1.18 or above, we recommend [**Controllable (Fabric)**](https://www.curseforge.com/minecraft/mc-mods/controllable-fabric). | |||
There was a problem hiding this comment.
I think we should still recommend midnightcontrols as its on modrinth and doesn't have any dependency and just list controllable for fabric as an alternative
There was a problem hiding this comment.
That sounds like a great idea. Though you should definitely change "Controllable" to "Controllable (Forge)" to reflect its name change on the page.
|
oops i think i caused a merge conflict, can you rebase? |
|
I'll have a look over this controller landscape has changed a bit. also need to fix the merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Controllable (Fabric) mod and corrects "Controllable" to "Controllable (Forge)" to stay up to date.