This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
Always build benchmarks and tests #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforce build of tests and benchmarking when building the lib, to avoid needless recompilations. Also, update the documentation with recommended commands for not running tests or benchmarks when that is undesired.
marmitar
force-pushed
the
feat/build-all
branch
from
5d1b809 to
ee1ca4f
Compare
leonardosrodrigues0
approved these changes
Sep 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
stack.yamlso benchmarks and tests are built with the library. Similar to how cabal did it withcabal build --all.The downside is that tests and benchmarks are always executed too (see commercialhaskell/stack#4977). One option to circumvent it is to enable
no-run-testsandno-run-benchmarks, but that won't let us run these components later on (see this comment). My proposed solution here is to use these options in the command line (and recommend them in the README), since forgetting them and running the benchmarks is not as bad as losing the option to run them at all.