Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added middleware compatible with JWT #43

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BhagatHarsh
Copy link
Contributor

Description

Added the middleware folder and the file auth.middleware.js containing the middleware used for auth in protected routes. checked the middleware by creating a test route.

Related Issue

This pull request is based on the issue #12.

Motivation and Context

The files changed:

server/middlewares/auth.middleware.js

contains the main logic of the middleware which extracts the Bearer token from the auth headers and verifys it using the JWT library. deals with erros as needed.

server/routes/auth.routes.js

Created a protected test route which if successfuly authenticates then sends the users information back as a JSON object.

generating a new token

Screenshot (168)

request that was made using the token in the auth header

image

If token expires

image

@mirchandani-mohnish
Copy link
Collaborator

Is there no environment variable method to this? The private key should ideally never be exposed

@BhagatHarsh
Copy link
Contributor Author

If you want a .env file then i can definitely make one, the reason for me doing it the easy way is that the website is still in progress most of the URL's and sensitive information is open and just for testing. so when it is finished a new PRIV_KEY will be generated and then set as the environment variable.

@mirchandani-mohnish
Copy link
Collaborator

Agreed but then an additional pr will have to be made for the same

How about make an env variable and additionally comment out the keys and keep

@BhagatHarsh
Copy link
Contributor Author

@mirchandani-mohnish please review the changes.

@BhagatHarsh
Copy link
Contributor Author

Please review the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants