Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding accession Id filtering for counts #1012

Merged
merged 2 commits into from
Jul 5, 2024
Merged

adding accession Id filtering for counts #1012

merged 2 commits into from
Jul 5, 2024

Conversation

neildsouth
Copy link
Collaborator

@neildsouth neildsouth commented Jul 5, 2024 •
edited
Loading

Description

adds accession Id and changes the count to allow a filter to be passed

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@neildsouth neildsouth merged commit 150e36d into develop Jul 5, 2024
20 of 21 checks passed
@neildsouth neildsouth deleted the nds-addAccessionId branch July 5, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeBatt1989 JoeBatt1989 JoeBatt1989 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neildsouth @JoeBatt1989