Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nds improve logging #952

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Nds improve logging #952

merged 2 commits into from
Jan 31, 2024

Conversation

neildsouth
Copy link
Collaborator

adds an appname for easier log filtering

A few sentences describing the changes proposed in this pull request.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@neildsouth
adding first test
6f9a834 
Signed-off-by: Neil South <[email protected]>
@neildsouth neildsouth added the enhancement New feature or request label Jan 31, 2024
@neildsouth
improving logging
31cdba3 
Signed-off-by: Neil South <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@neildsouth neildsouth merged commit 69385b4 into develop Jan 31, 2024
20 of 21 checks passed
@neildsouth neildsouth deleted the nds-logging branch January 31, 2024 10:33
@mocsharp mocsharp modified the milestones: 0.1.30, 0.2.0 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNuttall-AD DanielNuttall-AD DanielNuttall-AD approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neildsouth @DanielNuttall-AD @mocsharp