Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript for events #222

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Javascript for events #222

merged 1 commit into from
Jan 8, 2025

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Jan 8, 2025

Per slack discussion

Sorry my git repo had too many commits on main.

@jukent jukent requested a review from a team as a code owner January 8, 2025 20:34
@jukent jukent requested review from ktyle and erogluorhan and removed request for a team January 8, 2025 20:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 127c726
✅ Deployment Preview URL: https://ProjectPythia.github.io/cookbook-gallery/_preview/222

@jukent jukent requested a review from brian-rose January 8, 2025 20:35
brian-rose
brian-rose approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really speak Javascript so I could be missing something, but it looks good to me, and the functionality is there in the preview!

@brian-rose brian-rose mentioned this pull request Jan 8, 2025
Open
@brian-rose brian-rose merged commit a22b1e3 into ProjectPythia:main Jan 8, 2025
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
@brian-rose @github-actions
Delete preview for pull request \#222
0d9b995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-rose brian-rose brian-rose approved these changes

@ktyle ktyle Awaiting requested review from ktyle ktyle is a code owner automatically assigned from ProjectPythia/infrastructure

@erogluorhan erogluorhan Awaiting requested review from erogluorhan erogluorhan is a code owner automatically assigned from ProjectPythia/infrastructure

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jukent @brian-rose