-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite of the Pyomo Set component hierarchy #1111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1111 +/- ##
==========================================
+ Coverage 69.58% 70.46% +0.87%
==========================================
Files 530 532 +2
Lines 78478 80711 +2233
==========================================
+ Hits 54612 56872 +2260
+ Misses 23866 23839 -27
Continue to review full report at Codecov.
|
This should be ready to discuss/review. Tests all pass, and coverage is good: overall project coverage is up 0.87% and the new Set code is covered at 100%. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. I even checkout out the branch and used the new sets. I created an issue for the only problem I ran into.
Fixes #326
Summary/Motivation:
This implements the rewrite of the Pyomo Set component as specified in PEP #326
NOTE: This PR does NOT switch Pyomo over to using the new Set system. Everything is implemented in parallel to the existing system. A second PR will switch Pyomo over to the new system later.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: