Resolve timeout()
failures on Windows/py3.13
#3415
Merged
+36
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
The
timeout()
decorator was failing intermittently on Windows under Python 3.13. We would either see errors like:or
I was never quite able to determine why the test was suddenly failing (I suspect that there may actually be a bug in Python 3.13's implementation of Queue). This PR "resolves" the problem by switching from using a
multiprocessing.Queue
to communicate results back from the child process to the simplermultiprocessing.Pipe
. Whereas previously we were seeing the error about 1/3 of the time (out of 25 runs, 7 failed, and 1 hung indefinitely), with this new implementation 25 attempts all passed.Changes proposed in this PR:
multiprocessing.Queue
tomultiprocessing.Pipe
for communicating results back from the subprocessLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: