Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.8 support #3421

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Remove Python 3.8 support #3421

merged 3 commits into from
Nov 18, 2024

Conversation

mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Nov 15, 2024

Fixes NA

Summary/Motivation:

Remove Python 3.8 support because it is EOL.

Changes proposed in this PR:

  • Remove all references to 3.8 in tests and docs
  • Remove code that was necessary for pre-3.8 reasons

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Member

@jsiirola jsiirola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are removing necessary documentation that has nothing to do with Python 3.8 compatibility. These overloads are for helping out with IDE auto-completion / documentation and should not be removed.

pyomo/core/base/set.py Outdated Show resolved Hide resolved
@mrmundt mrmundt requested a review from jsiirola November 15, 2024 21:39
@mrmundt mrmundt merged commit 9996abe into Pyomo:main Nov 18, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants