Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify we are testing all NEOS solvers #3433

Merged
merged 7 commits into from
Nov 26, 2024
Merged

Conversation

jsiirola
Copy link
Member

Fixes #N/A.

Closes #3321

Summary/Motivation:

This is a small PR to test that we are actually testing all NEOS AMPL solvers. As part of this, it moves the logic for identifying all compatible NEOS solvers to a public method on the kestrelAAMPL interface.

By checking that we are testing against all advertised NEOS AMPL solvers, we can close #3321 (if Octeract is added back to the list of advertised solvers, then the test will start failing and we can revisit that issue).

Changes proposed in this PR:

  • Add kestrelAMPL.getAvailableSolvers()
  • Add a test that verifies RunAllNEOSSolvers has a test method for every solver.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Member

@blnicho blnicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one typo

pyomo/neos/kestrel.py Outdated Show resolved Hide resolved
Co-authored-by: Bethany Nicholson <[email protected]>
@mrmundt mrmundt merged commit d3f0bf5 into Pyomo:main Nov 26, 2024
36 checks passed
@jsiirola jsiirola deleted the neos-test-solvers branch November 26, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEOS/octeract interface is failing tests
4 participants