-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solver Refactor Part 2: Reduce Duplication & Restructure for Future Redesign #3447
Closed
+2,193
−1,525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmundt
requested review from
jsiirola,
michaelbynum,
whart222,
Robbybp and
blnicho
December 17, 2024 20:12
Temporarily closing because I didn't realize Windows was being problematic... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1030 (partly)
Summary/Motivation:
This does not fully complete the solver refactor (though let's be honest, it'll never really be "done") and builds on the work introduced in #3137. This is a "save state", however, that introduces HiGHs into the new solver interfaces as well as introduces necessary restructuring for clarity and future changes.
There is minimal functionality change for users as a result of this PR. The main new things they will see are:
highs_v2
gurobi_v2
togurobi_persistent_v2
Results.solver_configuration
toResults.solver_config
Changes proposed in this PR:
highs_v2
interfacecontrib/solver
to havecommon
,solvers
, andtests
solution
->solution_loader
)assert_optimal_termination
andcheck_optimal_termination
to make it forwards and backwards compatiblepylint
suggestions (because static analysis is good!)Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: