Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private name sales to consensus #183

Closed
wants to merge 1 commit into from

Conversation

QuickMythril
Copy link

This branch adds the functionality for private name sales, allowing someone to specify which address can buy, when selling a name. This would also allow them to set the cost to 0 (for private sales only), effectively "giving" someone a name, though it would still require the recipient to "accept" (purchase for 0). This implementation is complete, however it should be tested network-wide on a testnet. Also before mainnet release, it should probably set to trigger at a specific block in the future, to ensure that all nodes will be updated before any changes to consensus. This code has been reviewed and planned very carefully and deliberately, and even some of the variable names were chosen specifically to avoid issues or further complicating things. However, if there are any questions or suggestions for alternatives, any responses here are greatly encouraged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant