Add private name sales to consensus #183
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds the functionality for private name sales, allowing someone to specify which address can buy, when selling a name. This would also allow them to set the cost to 0 (for private sales only), effectively "giving" someone a name, though it would still require the recipient to "accept" (purchase for 0). This implementation is complete, however it should be tested network-wide on a testnet. Also before mainnet release, it should probably set to trigger at a specific block in the future, to ensure that all nodes will be updated before any changes to consensus. This code has been reviewed and planned very carefully and deliberately, and even some of the variable names were chosen specifically to avoid issues or further complicating things. However, if there are any questions or suggestions for alternatives, any responses here are greatly encouraged.