Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Progression] Implement Match Goals menu and XP tracking #756

Merged
merged 32 commits into from
Jun 28, 2024

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Oct 22, 2023

Currently Match Goals menu is unused and will never update properly regardless if player is earning XP through matches, for the post summary screen all of that will count as Double XP due to improper leveling tracking of where each XP point is going into, so this PR should fully implements and integrates _challenges.gnut script, solving this problem.

  • Implement Weapon Leveling tracking
  • Implement Titan Leveling tracking
  • Implement Match Score for all vanilla gamemodes
  • Implement Match Complete bonus
  • Implement Match Won bonus
  • Implement Successful Evac bonus
  • Implement Squad Leader bonus
  • Implement proper Double XP tracking
  • Implement Faction Leveling tracking (invisible in esc menu, but counts in post-summary)
  • Properly Rewards Advocate Gifts for leveling anything

Clipboard01

@Zanieon Zanieon added feedback wanted Feedback is wanted whether the changes by this PR are desired vanilla parity labels Oct 22, 2023
Apparently, those checks are used only cosmetically by the Post-Summary panel.
@Zanieon Zanieon marked this pull request as ready for review November 5, 2023 20:37
@Zanieon Zanieon added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 5, 2023
@Zanieon
Copy link
Contributor Author

Zanieon commented Nov 5, 2023

All of vanilla gamemodes have proper hooks for their Merit Score Challenges now, shall i expand that into custom ones located in Northstar.Custom?

Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good at a glance

@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Jan 21, 2024
@AshesToAshes76
Copy link

Not able to test the code at the moment, but having a better/working xP + merit system would greatly improve the Vanilla experience and give players who want to have Progression enabled more options to permanently unlock weapons, titans, and skins.

@Zanieon
Copy link
Contributor Author

Zanieon commented Jun 27, 2024

Can we please get this merged, i have other stuff to PR which i considers the implementation of this PR on them.

@GeckoEidechse
Copy link
Member

I'm assuming you tested this a bunch on your FD servers? ^^

@Zanieon
Copy link
Contributor Author

Zanieon commented Jun 27, 2024

I integrated this already in my FD branch, so all FD servers being hosted right now shows this PR working.

EDIT: Integrated it MONTHS ago.

Copy link
Contributor

@Klemmbaustein Klemmbaustein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some weird issues when first testing first, but after checking out the PR again it worked fine.

Match goals and XP tracking are working and I don't see anything wrong with the code.

@Jan200101
Copy link

Tested on a local listen server
Appears to do what it says on the tin
image

I initially tried testing it with attrition but FlightCore installs PRs without installing a navmesh so I had to manually spawn them in

@Jan200101 Jan200101 removed the needs testing Changes from the PR still need to be tested label Jun 28, 2024
Copy link

@Jan200101 Jan200101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good overall and follows established patterns.
Lots of it is just checking if a goal has been completed. and informing the client accordingly.

@Jan200101 Jan200101 added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs code review Changes from PR still need to be reviewed in code labels Jun 28, 2024
@Jan200101
Copy link

unsure if any more feedback is needed @GeckoEidechse

@GeckoEidechse
Copy link
Member

Thanks so much for the review and the ping <3

@GeckoEidechse GeckoEidechse removed feedback wanted Feedback is wanted whether the changes by this PR are desired almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Jun 28, 2024
@GeckoEidechse
Copy link
Member

Merging based on reviews o7

@GeckoEidechse GeckoEidechse merged commit 6581c4e into R2Northstar:main Jun 28, 2024
3 checks passed
@Zanieon Zanieon deleted the match_goals_tracking branch July 3, 2024 19:29
@GeckoEidechse GeckoEidechse added the progression Changes related to progression system label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
progression Changes related to progression system vanilla parity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants