-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Progression] Implement Match Goals menu and XP tracking #756
[Progression] Implement Match Goals menu and XP tracking #756
Conversation
Apparently, those checks are used only cosmetically by the Post-Summary panel.
All of vanilla gamemodes have proper hooks for their Merit Score Challenges now, shall i expand that into custom ones located in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good at a glance
Not able to test the code at the moment, but having a better/working xP + merit system would greatly improve the Vanilla experience and give players who want to have Progression enabled more options to permanently unlock weapons, titans, and skins. |
Titan leveling would still reward Advocate Gift even with progression disabled.
Can we please get this merged, i have other stuff to PR which i considers the implementation of this PR on them. |
I'm assuming you tested this a bunch on your FD servers? ^^ |
I integrated this already in my FD branch, so all FD servers being hosted right now shows this PR working. EDIT: Integrated it MONTHS ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some weird issues when first testing first, but after checking out the PR again it worked fine.
Match goals and XP tracking are working and I don't see anything wrong with the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good overall and follows established patterns.
Lots of it is just checking if a goal has been completed. and informing the client accordingly.
unsure if any more feedback is needed @GeckoEidechse |
Thanks so much for the review and the ping <3 |
Merging based on reviews o7 |
Currently Match Goals menu is unused and will never update properly regardless if player is earning XP through matches, for the post summary screen all of that will count as Double XP due to improper leveling tracking of where each XP point is going into, so this PR should fully implements and integrates
_challenges.gnut
script, solving this problem.